Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32: repairing minor breakage so the notebooks run again #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bruhwiler
Copy link
Member

No description provided.

@bruhwiler bruhwiler requested a review from cchall April 3, 2022 23:37
Copy link
Member

@cchall cchall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing_rsbeams_decoherence runs fine for me and mostly looks alright. Though looking back at it I think I wrote this as more of a regression test. I did not document it very well for an example.

In example-NLI-construction it's probably better just to remove the code for NonlinearInsert defined in the notebook. It isn't being used and there is a link to the nonlinear module in the notebook description at the top.

If we really want to show the code in the notebook this code block be replaced with nonlinear.NonlinearInsert??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants